| commit | 6da3d7ace9da93514c50281436bcf0fb66d50f18 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon May 17 16:24:09 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue May 18 02:12:20 2021 +0000 |
| tree | 0e5d77956b870e4d5f899ee155fe63ecbc569001 | |
| parent | 8f301ca0d3249a0e57d67a89d29ffa15c21f39fa [diff] |
internal/lsp/source: re-parse if needed when collecting identifier info With the new ParseExported logic, we can lose some unexported fields on exported structs. This can lead to misleading or malformatted hover information. Fix this by ensuring we always extract the Spec from a full parse. Since this path is only hit via user-initiated requests (and should only be hit ~once per request), it is preferable to do the parse on-demand rather than parse via the cache and risk pinning the full AST for the remaining duration of the session. For golang/go#46158 Change-Id: Ib3eb61c3f75e16199eb492e3e129ba875bd8553e Reviewed-on: https://go-review.googlesource.com/c/tools/+/320550 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.