| commit | 6a3bc37a9d8dd9f821c97824fe0c3e552726045c | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Fri Jan 06 17:45:14 2023 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Tue Jan 10 20:05:48 2023 +0000 |
| tree | 6a99fed3d6a7dda69bd178734fb584b46efc0f93 | |
| parent | 6e9a35db6103921bfaf0c26fc9d3b9a2ad36fe58 [diff] |
gopls/internal/lsp/protocol: reimplement ColumnMapper line logic
Before, ColumnMapper relied on token.File and various workarounds
such as span.OffsetToLineCol8 and ColumnMapper.OffsetPosition
and span.OffsetToLineCol8. Now it implements all the mapping
from byte offsets to/from (line, column) itself, using logic
mostly plundered from lsppos.Mapper.
The line number table is initialized lazily on first use,
since only a few percent of instances actually need it.
ColumnMapper now returns span.Point values that are fully
populated (offset and line+col), and now accepts both kinds
of partly populated Point value.
Also:
- rename Point to PositionPoint
and Offset to PositionOffset
and document the naming convention.
- group conversion methods by argument domain.
- add TODOs for an upcoming big renaming.
- the span package no longer cares about UTF-16.
Most of its tests were saved.
Change-Id: If6075b6087e30a1a7e773f2a7dfe1a441adf3497
Reviewed-on: https://go-review.googlesource.com/c/tools/+/460975
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.