commit 69daaf961d656fa9386db3c8b1d77c4295e82947
author Pontus Leitzler <leitzler@gmail.com> Wed Nov 11 13:12:26 2020 +0100
committer Robert Findley <rfindley@google.com> Wed Nov 11 13:33:15 2020 +0000
tree 7e887cf9412eb381b4c31fe9847e985d418c9fb6
parent 7099162a900ae8260c5b97cfaf5f374243dfa742

internal/lsp: do not treat failed go test commands as errors

The "go test" command invoked via code action/code lens performs a
ShowMessage callback to the client when the test is done.

Previously it did set severity to "Error" when the test failed, but a
failing test isn't a error condition per se. This changes the result to
be of severity Info for both successful and failed test invocations.

Change-Id: Ib76558d98a434c706823617b9901a88e53864319
Reviewed-on: https://go-review.googlesource.com/c/tools/+/269257
Run-TryBot: Pontus Leitzler <leitzler@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Daniel Martí <mvdan@mvdan.cc>

internal/lsp/command.go

diff --git a/internal/lsp/command.go b/internal/lsp/command.go
index 20ae57f..b205fc0 100644
--- a/internal/lsp/command.go
+++ b/internal/lsp/command.go
@@ -355,14 +355,12 @@
 	} else if failedBenchmarks > 0 {
 		message = fmt.Sprintf("%d / %d benchmarks failed", failedBenchmarks, len(benchmarks))
 	}
-	messageType := protocol.Info
 	if failedTests > 0 || failedBenchmarks > 0 {
-		messageType = protocol.Error
 		message += "\n" + buf.String()
 	}
 
 	return s.client.ShowMessage(ctx, &protocol.ShowMessageParams{
-		Type:    messageType,
+		Type:    protocol.Info,
 		Message: message,
 	})
 }