commit | 68c6cab8b7077063992714f2d1bc2f274a79cf5a | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Tue May 04 09:54:41 2021 -0700 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed May 05 20:44:55 2021 +0000 |
tree | f75d1385f7d39f04d2aee07774af11b16b087d2e | |
parent | 250398d0b32d7536aa20ae0a435a838a5128718d [diff] |
lsp/completion: improve append() param type inference In cases like: append([]string{}, foo<>) we now prefer objects of type string at <>. Previously we had no preference. In particular, we now try to infer the slice type from the first append() arg instead of only from the outer context of the append() call. Fixes golang/go#43240. Change-Id: I59dfa3b18892c5c87fc5ff53109f51f50ee03d26 Reviewed-on: https://go-review.googlesource.com/c/tools/+/316849 Run-TryBot: Muir Manders <muir@mnd.rs> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Heschi Kreinick <heschi@google.com> Trust: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.