tree 6aaed4682b747cb85cec3e29e87f6ee9099595f1
parent 6d71ab8aade08605ffc36622332264e2f6991952
author Michael Matloob <matloob@golang.org> 1541798685 -0500
committer Brad Fitzpatrick <bradfitz@golang.org> 1542039882 +0000

go/packages: fix flaky TestJSON and reenable it on Go 1.10

The fallback driver wasn't returning the roots in a
deterministic order because it was using sticking them in
a map and then iterating over that map to get each element.
Put them into a slice instead (and make a few small
associated changes) to preserve behavior.

Fixes golang/go#28040
Fixes golang/go#28609

Change-Id: Ib8f8c88d65b7a48b2b04ca91e2d3c316d5bb5803
Reviewed-on: https://go-review.googlesource.com/c/148880
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>