| commit | 67e49ef2d0f326051e22a4a55bdf9344ae1a8ed8 | [log] [tgz] |
|---|---|---|
| author | Matthew Dempsky <mdempsky@google.com> | Wed Feb 17 13:32:28 2021 -0800 |
| committer | Matthew Dempsky <mdempsky@google.com> | Thu Feb 18 03:45:40 2021 +0000 |
| tree | 79162ed119912eaa9ccde12e5046676e99e2878d | |
| parent | 19ff21fbe961b2d860bc361eac0fde77ec1bf187 [diff] |
go/internal/cgo: set pkgdir with -srcdir instead of CWD If pkgdir uses a symlink (e.g., how the macOS builders are currently setup for their GOROOT, due to how /var and /tmp work there), then changing into that directory to invoke cgo means that cgo will only be able to see the actual directory it was run from. This can lead to inconsistencies with code that expects to see the original symlink-based path. This CL changes go/internal/cgo to instead use cgo's -srcdir flag so that cgo can emit //line directives with the symlink paths instead. Fixes golang/go#44339. Change-Id: I3cbee6753454922711c8c70d7c64a02565b8bb4c Reviewed-on: https://go-review.googlesource.com/c/tools/+/293250 gopls-CI: kokoro <noreply+kokoro@google.com> Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.