commit | 9611592c72f63638cf256c3dcd605a106f4aa79d | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Tue Dec 03 19:56:44 2019 -0500 |
committer | Heschi Kreinick <heschi@google.com> | Wed Dec 04 01:13:08 2019 +0000 |
tree | f42757876154580175f139b1957e58e64340139f | |
parent | b1451cf3445bfc43d9982a3e85bec2dacced42ce [diff] |
internal/lsp/cache: fix load race, refactor As far as I can tell, the code I removed in from load did roughly nothing -- returning nil metadata didn't suppress type checking as I think was intended. Throwing away the metadata also created the race in Pull the check for missing import changes up to PackageHandles, where it is non-racy and can cause type checking to be skipped. Simplify and refactor. Fixes golang/go#35951. Change-Id: Id4b32b86569afb36863aaf982616b2b3727b0e83 Reviewed-on: https://go-review.googlesource.com/c/tools/+/209737 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.