commit | c537a342ddf6c0a44a4f7b5eafa9be47eb9bd29e | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Sun Sep 13 00:26:21 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed Sep 16 22:53:23 2020 +0000 |
tree | 0240c73e50574ede196b04dc6995503f6b609e4f | |
parent | c9a70fc28ce398a63d7835370de575fec20f826e [diff] |
internal/lsp: pass options by reference instead of by value We were previously behaving as though the slice/map values in the options struct could be modified directly. The options should be cloned before modification. Also, convert any usage of source.Options to *source.Options. Fixes golang/go#39592 Change-Id: Ib39f668bca0fa1038162206bd7793fd2049af576 Reviewed-on: https://go-review.googlesource.com/c/tools/+/254558 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.