tree e2a6628b40465cdaa91898783b93dcaba02a96ca
parent f9c628b18cad3112e24df69a34dd0a46a6e66ec3
author Heschi Kreinick <heschi@google.com> 1614282429 -0500
committer Heschi Kreinick <heschi@google.com> 1614650691 +0000

internal/lsp/cache: invalidate metadata on magic comment changes

When a //go:embed or //go:build (//+build) line changes, we need to
invalidate metadata. Do so. It might be preferable to only invalidate on
save, but we don't currently have an approach for doing that. So for now
we'll load on each keystroke in a magic comment.

Fixes golang/go#38732, golang/go#44342.

Change-Id: Id05fb84f44215ea6242a7cf8b2bca4e85f74680e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/296549
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>