tree ac5761fe33f5eebd61c82ce5a84941e4695b92c1
parent 59bd4faed9b3724797fdffa7c1476ff8fb8a4878
author Alan Donovan <adonovan@google.com> 1655416707 -0400
committer Alan Donovan <adonovan@google.com> 1655842542 +0000

internal/lsp/cache: minor simplifications to Symbols

Minor cleanups based on studying the code in preparation
for saving a persistent index:

- Remove unused error result from Symbols method.
- Remove unnecessary fields from symbolHandle.
- Add various explanatory comments.
- In workspace_symbols.go:
  - separate extract and match phases of collectSymbols clearly
  - replace symbolCollector and matchWorker types by simple parameters
  - combine loops (roots, buildMatcher)
  - move buildMatcher creation down to where it is needed.

Change-Id: Ifcad61a9a8c7d70f573024bcfa76d476552ee428
Reviewed-on: https://go-review.googlesource.com/c/tools/+/412822
Reviewed-by: Robert Findley <rfindley@google.com>