tree 6df75be1b72fa20285c1979973954124f71fd7c3
parent 5128de728888ea5cc98be50b4efaabc4d3491274
author Alan Donovan <adonovan@google.com> 1497893603 -0400
committer Alan Donovan <adonovan@google.com> 1497894344 +0000

go/loader: fix a data race

The loader was calling (*types.Checker).Files on the "unsafe" package,
a global variable.  Even with zero files, this operation is not a no-op
because it sets the package's "complete" flag, leading to a data race.
(Because Unsafe.complete is already set at construction, the
race is benign, but is reported by -race nonetheless.)

Fixes golang/go#20718

Change-Id: I5a4f95be5ab4c60ea3b6c2a7fb6f1b67acbf42bc
Reviewed-on: https://go-review.googlesource.com/46071
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>