commit | 6397a11608adffeb57d160dcd4ec22c9d9d4c4c9 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Tue Apr 27 10:07:56 2021 -0400 |
committer | Robert Findley <rfindley@google.com> | Tue Apr 27 15:36:10 2021 +0000 |
tree | 357e0a1bf669fbd0824049a34200e1d2f8c12c9f | |
parent | 7b9993c5d26898de3b6451cf64a1f91bd721f374 [diff] |
internal/lsp/debug: splice in updated servers rather than overwrite Updating server info was racing with rendering debug templates, because the state mutex only guards the servers slice, not the values contained in that slice. Switch to splicing in updated server data, rather than updating in-place, to avoid the race. Change-Id: Ia69895b49cf3f961c58db8e6512ce8b1f5911fd3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/314169 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.