tree 095111bd821699486ed02e0f7c3fff00e41b6545
parent e140590b16906206021525faa5a48c7314806569
author Heschi Kreinick <heschi@google.com> 1575570256 -0500
committer Heschi Kreinick <heschi@google.com> 1575571114 +0000

internal/memoize: fix race on read of handle.function

Late into CL 206879 I started nulling out a handle's function when the
handle finished running. That invalidated a previous assumption that the
field was immutable. Fix the assumption, and since the case of having
multiple computations in flight is at least a little bit possible, try
harder to avoid duplicate work.

Fixes golang/go#35995.

Change-Id: Ib5e3640f931f95e35748f28f5a82cf75585b305d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210077
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>