| commit | 61fa4dffed09fb8cad42837dbc5fc1275d09624a | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Thu Dec 05 13:24:16 2019 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Thu Dec 05 18:38:34 2019 +0000 |
| tree | 095111bd821699486ed02e0f7c3fff00e41b6545 | |
| parent | e140590b16906206021525faa5a48c7314806569 [diff] |
internal/memoize: fix race on read of handle.function Late into CL 206879 I started nulling out a handle's function when the handle finished running. That invalidated a previous assumption that the field was immutable. Fix the assumption, and since the case of having multiple computations in flight is at least a little bit possible, try harder to avoid duplicate work. Fixes golang/go#35995. Change-Id: Ib5e3640f931f95e35748f28f5a82cf75585b305d Reviewed-on: https://go-review.googlesource.com/c/tools/+/210077 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.