tree bd3aa17ec6581ef5992f52f7b050d01287684629
parent e7b5a6dfd88b61ac7c2f61acb9f83cffb4b4f3fa
author Steven L <imgroxx@gmail.com> 1546115084 +0000
committer Michael Matloob <matloob@golang.org> 1546976242 +0000

go/analysis/internal/checker: don't clobber error when packages.Load fails

Previously, if `packages.Load` failed, it would (sometimes? always?) return an error + no initial packages.
The moved `len(initial)` check was overriding the actual err with a much less useful one.

Example output before:
```
13:03:17.856866 load [./...]
13:03:28.403532 ./... matched no packages
```
And after:
```
13:03:30.942191 load [./...]
13:03:36.999506 go list repeated package [an internal package] with different values
```

Change-Id: I1a821e3855cbbbee904bcec9c29877e091c3e3a0
GitHub-Last-Rev: d1235fc2eceb0d4e947f47be99edc5ac96da5f84
GitHub-Pull-Request: golang/tools#65
Reviewed-on: https://go-review.googlesource.com/c/155745
Reviewed-by: Michael Matloob <matloob@golang.org>