commit 5c5c4f4888847d89d377b04ba4e7c847dd08c957
author Alan Donovan <adonovan@google.com> Thu Jun 19 15:30:51 2014 -0400
committer Alan Donovan <adonovan@google.com> Thu Jun 19 15:30:51 2014 -0400
tree f5c14c00497d051dd2811d1e9b16ef1f6c8cfda1
parent 5fe8afcb15d7671a315928d3b8ad38401c4d62e5

go/pointer: fix crash: valueNode(*FreeVar) was allocating 1 node, even for multi-word types.

+ regression test.

Fixes golang/go#8172

Also: return error (not panic) when called with empty input.

LGTM=gri
R=crawshaw, gri
CC=golang-codereviews, jon
https://golang.org/cl/104270043

go/pointer/gen.go

diff --git a/go/pointer/gen.go b/go/pointer/gen.go
index 8643545..e2b7da9 100644
--- a/go/pointer/gen.go
+++ b/go/pointer/gen.go
@@ -226,7 +226,7 @@
 		if a.log != nil {
 			comment = v.String()
 		}
-		id = a.addOneNode(v.Type(), comment, nil)
+		id = a.addNodes(v.Type(), comment)
 		if obj := a.objectNode(nil, v); obj != 0 {
 			a.addressOf(v.Type(), id, obj)
 		}