tree 9f4dda58283d794db2d96a0e1adc39f33bd0be5e
parent 45586ddbaa717f86f7f30a021d0d1305bc43de11
author Muir Manders <muir@mnd.rs> 1605981132 -0800
committer Rebecca Stambler <rstambler@golang.org> 1606147168 +0000

internal/lsp: fix godef for embedded type aliases

In

    type myAlias = someType
    type _ struct {
      myAlias
    }

Previously running "definition" on the "myAlias" field would take you
to the definition of "someType" instead of "myAlias". This is because
we were using the field's (*types.Var).Type() which has already
forgotten it is an alias. Fix by instead looking up the field name
ident in types.Info.Uses which yields the *types.TypeName (for the
type alias).

Fixes golang/go#42254.

Change-Id: Idbbd0c49ba6f701f52568b3ab1143d8e24037c69
Reviewed-on: https://go-review.googlesource.com/c/tools/+/272186
Run-TryBot: Muir Manders <muir@mnd.rs>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Muir Manders <muir@mnd.rs>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>