| commit | 322816044c6cd7638d0b0802326ccab576518342 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon Aug 02 19:48:26 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue Aug 03 15:39:08 2021 +0000 |
| tree | 45e342f39d13a8087cbfa4661c8c6f198becbac6 | |
| parent | 3395cb03f1be0b7cc2948b57b23762dc084b6267 [diff] |
internal/typeparams: update x/tools for recent typeparams changes Recent changes to the go/ast APIs for type parameters have broken the internal/typeparams package when built with -tags=typeparams. Fix this by adjusting the internal/typeparams API. Also update a few tests accordingly. Bump the build constraint used by the internal/typeparams package to go1.18, as we are no longer compatible with the 1.17 typeparams API. It is no long possible to opt in to type parameter specific functionality 1.17, which is fine as the dev.typeparams branch has moved to 1.18. Even after these fixes, not all x/tools tests pass with go1.18. Some completion tests are failing due to finding 'any' in types.Universe. Change-Id: I5f92870aaf7853e531e3a154987f98520a52d70c Reviewed-on: https://go-review.googlesource.com/c/tools/+/339349 Trust: Robert Findley <rfindley@google.com> Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.