commit | b261fe96097f8db197a1033090651783e8eb8350 | [log] [tgz] |
---|---|---|
author | Keith Randall <khr@golang.org> | Wed Apr 07 14:11:39 2021 -0700 |
committer | Keith Randall <khr@golang.org> | Thu Apr 08 02:08:45 2021 +0000 |
tree | bca8dc5360ef95f50475bc687473c37f77aa9e6c | |
parent | e78b40c7d0f9973e4a8ae8836f4b2131292d5609 [diff] |
go/tools: add vet check for direct comparion of reflect.Values Comparing reflect.Values directly is almost certainly not what you want. That compares reflect's internal representation, not the underlying value it represents. One compares reflect.Values correctly by comparing the results of .Interface() calls. Fixes golang/go#43993 Update golang/go#18871 Change-Id: I6f441d920a5089bd346e5431032780403cefca76 Reviewed-on: https://go-review.googlesource.com/c/tools/+/308209 Trust: Keith Randall <khr@golang.org> Trust: Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Keith Randall <khr@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.