tree b38f66b7bfacc0e598a3aaf331994a038ab36a06
parent f2c07d7d8ec107f5589424c895154fe91f433426
author Rebecca Stambler <rstambler@golang.org> 1594786750 -0400
committer Rebecca Stambler <rstambler@golang.org> 1594939803 +0000

internal/lsp: refactor go.mod diagnostics to simplify the API

Currently, diagnostics for modules that are missing from the go.mod
appear in the Go files in which those modules are imported. As a result,
the diagnostics were previously calculated as part of the Go file
diagnostic calculations. This is convoluted and required passing around
an extra map.

This CL puts that logic in the ModTidyHandle where it belongs.
The diagnostics for the Go files are combined from the multiple sources.

Also, added a skipped test for golang/go#39784, since this CL was
originally intended to be a fix for that issue...

Change-Id: Ic0f9aa235dcd56ea131a2339de9801346f715415
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242579
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>