tree f3832d5620ffe314b0166dcca9ddfd0f868f72dc
parent 63f8a171a61bbd68338d6ef6f3adc90794a765e4
author Paul Jolly <paul@myitcv.io> 1604060081 +0000
committer Paul Jolly <paul@myitcv.org.uk> 1604068372 +0000

internal/lsp/source: use bestMatch for fully qualified symbol style

Currently, fully qualified symbol style does a simple match against a
fully qualified symbol. However, this doesn't really match the user's
intent. Much like the dynamic style, the match should be done "from the
right" (per the logic of bestMatch) with the results being fully
qualified for presentational reasons.

We therefore reuse the logic from the dynamic symbol style, but instead
return a matched symbol as the fully qualified value.

Change-Id: I5c8c6b647c0710c5054bc8e27dbb29cb0fac14d8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/266557
Run-TryBot: Paul Jolly <paul@myitcv.org.uk>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Paul Jolly <paul@myitcv.org.uk>