tree d6e5f607c63476ca859b058a4fffd2d19f697c8e
parent 6ec2cde9631b17f6d67c79e2fe4c2a5d317b65f0
author Rob Findley <rfindley@google.com> 1600225912 -0400
committer Robert Findley <rfindley@google.com> 1600260019 +0000

gopls/internal/regtest: simplify expectation return values

Returning 'metBy' from expectations was not an ideal API, as extracting
the result value was cumbersome and error prone. It also forced quite a
bit of plumbing.

Using OnceMet, we can improve this by instead using a 'ReadDiagnostics'
expectation that reads diagnostics into a variable.

For golang/go#39384

Change-Id: Ia73e5b496089240df3200626e5696305cb507c9a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/255126
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>