| commit | 563860d11da684b1d3cbcbe4c57ecf43d099572b | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Thu Jan 09 19:14:18 2020 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Fri Jan 10 00:40:31 2020 +0000 |
| tree | 22c125c9ecfd7442fab7b4c3363fcbead64ce6b3 | |
| parent | 0a1579a33b0268e5c6cc226b86d3b89350a73cf7 [diff] |
internal/imports: fix use of uninitialized resolvers Resolvers are lazy initialized. That worked fine until the addition of the scan semaphore -- it's not a good idea to create that lazily, since you can't synchronize on a channel that doesn't exist. Specifically, this caused a gopls hang when completion finished without needing to use the resolver. In that case, we'd call ClearForNewScan/Mod on an uninitialized resolver, and then hang receiving from a nil channel. Instead, eagerly initialize where convenient, and particularly the scan semaphore. Change-Id: I3adb1ae76b751650995e50f50346e06fd9c9f88d Reviewed-on: https://go-review.googlesource.com/c/tools/+/214258 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.