commit | 5298e130f1a8339d852156b315adb392c3270d3c | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Fri May 29 15:51:01 2020 -0400 |
committer | Robert Findley <rfindley@google.com> | Wed Jun 03 13:18:45 2020 +0000 |
tree | 53c638d5910d98c769b72c5ba21121f211b1b18d | |
parent | 8a3674bff3730f6961ae8067bf0d30cd517d311b [diff] |
internal/lsp: lift up workdone instrumentation to didModifyFiles Previously, workdone reporting was managed by the goroutine(s) that compute diagnostics following a file change. The intention was to signal when diagnostics resulting from file changes were complete. This was buggy, in two ways: + When no snapshots are determined to require diagnosis, no work is reported. + If multiple snapshots required diagnosis, we'd get multiple work IDs. Fix this by lifting up the 'work' to the level of didModifyFiles. Change-Id: I73cf8bf9946dba777650bba9d4d18dad6954620e Reviewed-on: https://go-review.googlesource.com/c/tools/+/235738 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.