| commit | 51ce8377ebf8276585c091692a62fe5bb4fb4142 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Thu Jan 28 20:03:37 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Tue Feb 02 20:40:51 2021 +0000 |
| tree | 86609088a2f26226294e5cec8168f8ec99680dfa | |
| parent | 5659e49346c665d7a732ed6fc4b902633a20c06d [diff] |
internal/lsp: remove the source.Error type source.Error and source.Diagnostic are almost identical types, used arbitrarily in different parts of the code. This CL is the first step in cleaning up that redundancy: it deletes the source.Error type. To do that, I added the fields from source.Error to source.Diagnostic, and made absolutely no other semantic code changes -- I just renamed things that were named Error to Diagnostic. With only aesthetic concerns in play, I hope this CL will be easy to review. The next CL will clean up all the stupid-looking code that converts a Diagnostic to a Diagnostic, etc. Change-Id: I1298cc8144c686b8a37fc2cc106930105e511353 Reviewed-on: https://go-review.googlesource.com/c/tools/+/288214 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Go Bot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.