tree 42aaf53af7b90fde33f5e18d2440a81cbd81bf77
parent bf70295789942e4b20ca70a8cd2fe1f3ca2a70bd
author xieyuschen <xieyuschen@gmail.com> 1741842645 -0600
committer Gopher Robot <gobot@golang.org> 1741800094 -0700

gopls/internal/analysis/modernize: rangeint: avoid offering wrong fix

This change adds additional checking to ensure that rangeint
won't offer a fix in cases where RHS of 'i < limit' depends on loop var.

Given the code snippet below, this change will no longer offer a wrong fix as it did before.

	var n, kd int
	for j := 0; j < min(n-j, kd+1); j++ {
	}

- offered fix before(build error 'undefined: j')

	var n, kd int
	for j := range min(n-j, kd+1){
	}

Fixes golang/go#72726

Change-Id: I78c5457406258c44dd2fa861aa43d9ddb9c707fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/656975
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>