| commit | 4d9c4f8a78b0f1a3290e1d686b9334d5718b1e0c | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Wed Nov 18 16:11:35 2020 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Wed Nov 18 21:56:54 2020 +0000 |
| tree | 63736942a743fbd0adc506138a5c02cf2f79f09e | |
| parent | 1727ee11c454bd7fcf10ab3e38d4c543fa8213a4 [diff] |
internal/lsp/mod: speed up and simplify go.mod code lenses The tidy and upgrade code lenses first run the go command they represent, then show the lens if there are changes to be made. While this makes for a cleaner user experience, it also means that we're running a go command that hits the network in a synchronous code lens call. That's risky if the user is on a slow network connection. Removing the call does represent a change, possibly a regression, in UX. However, we already felt that the presentation of the upgrade option on each dependency line was too noisy. Therefore the only remaining benefit is that the lenses only appear when they have something to do. We've decided that's not sufficient justification. Remove the calls. We may recreate them as diagnostics in the future, so I've left ModUpgrade around. (ModTidy is still used by diagnostics.) Change-Id: I16c5eaebd1a50e5358c2addde9c1bb3f1182aac2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/271297 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.