tree 8a9715c2982958fe4bce8b9e46a488a7647c1f29
parent 7667e13ae93cf685de54af2caca6678d9f7618be
author Michael Matloob <matloob@golang.org> 1570826963 -0400
committer Michael Matloob <matloob@golang.org> 1570828716 +0000

go/packages: make a copy of the config.Env slice in the test.

Before this change, we were "saving" config.Env and then appending
to it to create a new slice, like so:

  savedEnv := config.Env
  ...
  // for each test case
    config.Env = append(savedEnv, additionalValue)

but we're modifying savedEnv during each env. Even though it might
work, it's not doing what we expect. Clean this up.

Change-Id: Idcf8199d836241df2b934308863512c566c0c485
Reviewed-on: https://go-review.googlesource.com/c/tools/+/200769
Run-TryBot: Michael Matloob <matloob@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>