Google Git
Sign in
go / tools / d54e12bfc5fbc3d948088c5f869a5dcd960f1e81
commitd54e12bfc5fbc3d948088c5f869a5dcd960f1e81[log] [tgz]
authorAlan Donovan <adonovan@google.com>Wed Nov 30 18:11:33 2022 -0500
committerAlan Donovan <adonovan@google.com>Thu Dec 01 21:30:09 2022 +0000
tree6018b0d1729af307efe09098d5e300f00c71a853
parent0379b73aefe056f088ad2d8727c4caff859503d4 [diff]
gopls/internal/lsp: avoid I/O in URI comparison operations

Previously, URI comparison would look at both the text
and then the inodes of the files, calling stat(2).
This was a muddling of two concerns, and caused I/O
operations in surprsing places, often when locks are
held.

Most callers need only a stable sort order for determinism;
they can use a simple textual comparison. Of the remainder:
- workspace.Clone uses a forked copy of the original,
  out of unrationalized fear.
- Session.NewView uses span.SameExistingFile, the pure I/O-based check.
- ColumnMapper.Range uses a weakened syntactic check;
  it just just an assertion (bug.Report).

Also, commit to honorSymlink=false and simplify the code
so that InDir and InDirLex become identical.

Closes golang/go#42833  (won't fix)

Change-Id: I984656a96144991908089eec101fd0df3c0e2477
Reviewed-on: https://go-review.googlesource.com/c/tools/+/454355
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
13 files changed
tree: 6018b0d1729af307efe09098d5e300f00c71a853
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.