commit | 47985cf3c742a03b71ec7bc1884c4bae906cd5ab | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Fri Feb 26 15:51:02 2021 -0500 |
committer | Heschi Kreinick <heschi@google.com> | Tue Mar 02 02:05:01 2021 +0000 |
tree | da6e6fadb1ececa4febf6430a7a6eb0d85f03dc5 | |
parent | 6422c5c8c7ed4d16817458e4be083e2807c874b3 [diff] |
internal/lsp/cache: refactor Go file parsing Hopefully improve some of the details around parsing that have always confused me. - parser.ParseFile will never return an error other than scanner.ErrorList. Encode that in ParsedGoFile. - parser.ParseFile will never return a nil file. Eliminate the code path that handled that. - Explain why we might fail to find a token.File. - Trying to fix errors appears quite expensive even if there aren't any to fix. Don't waste the time. Change-Id: I87e082ed52c98a438bc7fd3b29e1a486f32fb347 Reviewed-on: https://go-review.googlesource.com/c/tools/+/297069 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.