commit | 25dc3e1ccc3c22112721089cec64a69859b5d48b | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Wed Oct 28 21:17:07 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Thu Nov 19 05:40:27 2020 +0000 |
tree | edcdb445367793774bd0d502fb04e7f247985135 | |
parent | 4d9c4f8a78b0f1a3290e1d686b9334d5718b1e0c [diff] |
internal/lsp: handle deletion of a directory on disk The current DidModifyFiles logic does not handle the possibility of a directory URI in a didChangeWatchedFiles request. For creation and changes, this is fine because only file URIs matter in those cases, but for deletion, the deletion of a directory signifies the deletion of all of the files in it. Add handling for directories by looking up all of the known files in a given directory. We then create file modifications for all of those files, instead of the directory. Fixes golang/go#38422 Change-Id: I26d7b93285367fe116fd1cb3e8ec13a276f9e517 Reviewed-on: https://go-review.googlesource.com/c/tools/+/266138 Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Trust: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.