commit | 2b2ab33f9f3c0fad66477e1ca962f586967226f1 | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Wed Nov 06 13:23:43 2019 -0500 |
committer | Rebecca Stambler <rstambler@golang.org> | Thu Nov 07 00:20:28 2019 +0000 |
tree | c6caf37d453ecb401e755ea6f87476d498c47d52 | |
parent | 3af9f3e163a51c7abf3213b809bf984913ca4e15 [diff] |
internal/lsp/source: don't unconditionally name imports In CL 205501 I thoughtlessly set import name to package name, but really we only want to name imports when goimports would do it. For now, it's better to not name them and let the usual imports code add a name if necessary. Fixes golang/go#35397. Change-Id: Id0df866f95e5e86ed72b25fbd1a7224c79ee8084 Reviewed-on: https://go-review.googlesource.com/c/tools/+/205657 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> (cherry picked from commit c2ac6c2a2d7ef39f1c4c195d1cd731098986857f) Reviewed-on: https://go-review.googlesource.com/c/tools/+/205738 Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.