| commit | 46b69584a1dd507297e6e46e9017fe327f070d35 | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Thu Jan 19 15:54:50 2023 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Thu Jan 19 21:16:09 2023 +0000 |
| tree | 7ebe16aeb1496c9a953b16c01063d42b0f0b5039 | |
| parent | bcc7794c084e0fae686602a9d827752af568f98d [diff] |
gopls/internal/lsp/source: delete source_test The source test is one of three (partial) implementations of the tests.Tests interface, which defines the behavior of the marker tests. It makes direct calls to logic in the source package; the other two implementations make LSP RPCs (lsp_test) or fork+exec the gopls command (cmd_test). I have audited all the functions in source_test and satisfied myself that they provide no additional coverage beyond what is provided by lsp_test, and in some cases strictly less. A lot of logic was redundant. Ultimately, lsp_test is what matters, since the LSP is our main interface. Where there was any subtlety or discrepancy, I have remarked below. A few functions in source have been made unexported. This also removes 9s real, 18s CPU, from our CI builds. Details: - CompletionSnippet source_test had opts.Matcher = source.Fuzzy - DeepCompletion source_test had a FuzzyMatcher, but it never affected the outcome. - RankCompletion source_test failed to set these options used in the LSP test: opts.CompleteUnimported = false opts.LiteralCompletions = true - Import lsp_test invokes the broader textDocument/codeAction RPC where source_test called AllImportsFixes. - Definition source_test was calling FormatHover twice! - Rename the LSP implementation does strictly more (reports the file rename). Updates golang/go#54845 Change-Id: I1b0956d56540856dc0494f50ede0be7b7acc3e8e Reviewed-on: https://go-review.googlesource.com/c/tools/+/462816 Run-TryBot: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.