| commit | 4480df5f16277fac3c49dbd103521626b10718a5 | [log] [tgz] |
|---|---|---|
| author | Michael Matloob <matloob@golang.org> | Thu Apr 02 16:59:29 2020 -0400 |
| committer | Michael Matloob <matloob@golang.org> | Fri Apr 03 17:07:48 2020 +0000 |
| tree | 7c6e3eb88091ceb5a761aa2bad20e2d08b1e9177 | |
| parent | bcf690261a44a72824e7f28b8db2100a46fa0049 [diff] |
go/packages: only list current module's directory in determineRootDirs When determining the root directory of a module, the go list overlay code would do a go list -m all to get the module information for all modules. Stop doing that and only list the current module. This fixes an issue when users had overlays and were using automatic vendoring because go list -m all doesn't work with automatic vendoring. It isn't clear if overlays outside of the main module were ever working and overlays in the module cache don't make sense. There's a chance that this might break users with overlays in replaced directories, but it's not clear that that previously worked, and it wasn't tested. If this change causes breakages, we can use bcmills' suggestion in golang.org/issue/37629#issuecomment-594179751 point 3 to fix it. Fixes golang/go#37629 Change-Id: I826a86bbe54311cac72cbcafb2de4863dc805c2d Reviewed-on: https://go-review.googlesource.com/c/tools/+/227117 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.