commit | 42b62fc938697d734264c6554c8025d983a8cb49 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Sun Sep 27 21:17:14 2020 -0400 |
committer | Robert Findley <rfindley@google.com> | Mon Sep 28 11:28:10 2020 +0000 |
tree | db971d39a6f02b71bc9e99d2d1fc94d70c137a81 | |
parent | 5d1fdd8fa3469142b9369713b23d8413d6d83189 [diff] |
gopls/internal/regtest: fix data race when printing logs Lock around log access in regtests. This flake was relatively rare in regtests because of the serial nature of our jsonrpc2 implementation, but was nonetheless racy. Fixes golang/go#41653 Change-Id: I08674f42b05624a69d33885c2232c9e31866375b Reviewed-on: https://go-review.googlesource.com/c/tools/+/257957 Trust: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.