| commit | 40dabfa8588dfa55c3e1a503fae5302326cc4a9c | [log] [tgz] |
|---|---|---|
| author | Dylan Le <dungtuanle@google.com> | Wed Aug 03 14:45:51 2022 -0400 |
| committer | Dylan Le <dungtuanle@google.com> | Tue Oct 04 16:03:06 2022 +0000 |
| tree | d17e904451220a468c40864bc00aba770af9eb43 | |
| parent | 55e5cff61126558edd0ba9c5c2d06c8c29b8a499 [diff] |
gopls/internal/lsp: add support for package renaming Users can now rename packages by performing a rename on the package name in package declarations. The editor will prompt user with a dialogue text field to change the package name. This rename feature then do the following: - Rename all the external imports of the renaming package. In case there is renaming conflicts within a file, the feature repeatedly try fresh names constructed by appending new package name with number of try times so far until succeed. - Rename all the internal references to the renaming package from its files. - Rename the directory of the renamed package and update the imports' paths of any packages nested under the renamed directory. - Rename the test package with the new package name and suffix "_test" with the current test package name ends with "_test", or just the new package name otherwise. The regression tests accounts for these edge cases: - Only rename other known packages if the module path is same for both the renaming package and the other known packages. - Prevent renaming main package. - Test if the renaming package name is different from its path base. Todo: - Add a test for the case when the renaming package's path contains "internal" as a segment. - Allow edit to the whole package path not just only the last segment of the package path - Reject renaming if the renamed subpackages don't belong to the same module with the renaming package - Check the go.mod files in the workspace to see if any replace directives need to be fixed if the renaming affects the locations of any go.mod files Change-Id: I4ccb700df5a142c3fc1c06f3e5835f0f23da1ec5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/420958 Run-TryBot: Dylan Le <dungtuanle@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as go install golang.org/x/tools/cmd/goimports@latest.
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.