| commit | 3e1cb95235af786c5d1f0deffbd0b0646bf00024 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Fri Mar 05 11:18:47 2021 -0500 |
| committer | Robert Findley <rfindley@google.com> | Fri Mar 05 19:21:50 2021 +0000 |
| tree | 52d80442051c46b5746d3d66f470ee5969a074a5 | |
| parent | 397283d209ff9857e7ba6548904864400554f50a [diff] |
internal/lsp/source: correct workspace symbol logic for unpacking receivers The logic to extract the receiver identifier from a func decl was incorrect, accepting only the common T and *T syntaxes, and panicking on *(T). Fix this by copying the logic from go/types. Fixes golang/go#44806 Change-Id: I1c87ab21ac04e484972bc4161180ca1112df3c73 Reviewed-on: https://go-review.googlesource.com/c/tools/+/298852 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.