commit 3d82e7e94aea934d599326287f45bf5bf26868d7
author Alan Donovan <adonovan@google.com> Thu Jan 09 14:11:54 2014 -0500
committer Alan Donovan <adonovan@google.com> Thu Jan 09 14:11:54 2014 -0500
tree 86c5c590b80ae65c67d8a7febd8eaabec78daa32
parent df3357d07f16778acb02a9c183cb6b94639a010c

go.tools/ssa: fix crash in SSA builder when using GCImporter to satisfy imports (ssadump -build=G).

Packages were not being created for all types.Packages,
specifically, indirectly imported packages were missing.
(*Program).CreatePackages now iterates over the type-checker's
package map too.

Also: removed all concurrency from importer.  I think it was
incorrect (and hard to fix).

Also: change LoadInitialPackages so that all named packages
are loaded from source.  This happens regardless of whether
GCImporter is used to satisfy imports.

Details:
- importer.Config.SourceImports flag determines whether to
  load all packages from *.go source.
  (Before, this was indicated by Config.Build != nil.)
- importer.Config.Build field effectively defaults to
  &go/build.Default.  A zero importer.Config is now usable.
- importer.Importer.Config field is now exported.
- LoadPackage renamed to ImportPackage since the resulting
  packages may come from GCImporter (and be incomplete).
- doImport and ImportPackage fused.

Fixes golang/go#7028

R=gri, axwalk
CC=golang-codereviews
https://golang.org/cl/48770043