| commit | 3a5dbf351046aa8e826b87b452f0f28e082fc8cc | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Sun May 21 11:03:28 2023 -0400 |
| committer | Robert Findley <rfindley@google.com> | Mon May 22 17:44:12 2023 +0000 |
| tree | d028b3e7b158362f68f5ceeb07e35934580ff5e3 | |
| parent | 3c025517650c76973a2bfc9e152fdde66aae77b7 [diff] |
gopls: add a new "subdirWatchPatterns" setting As discovered in golang/go#60089, file watching patterns behave very differently in different clients. We avoided a bad client-side bug in VS Code by splitting our subdirectory watch pattern, but this appears to be very expensive in other clients (notably coc.nvim, or any vim client that uses watchman). The subdirectory watch patterns were only known to be necessary for VS Code, due to microsoft/vscode#109754. Other clients work as expected when we watch e.g. **/*.go. For that reason, let's revert all other clients to just use simple watch patterns, and only specialize to have subdirectory watch patterns for VS Code. It's truly unfortunate to have to specialize in this way. To paper over this hole in the wall, add an internal setting that allows clients to configure this behavior explicitly. The new "subdirWatchPatterns" setting may accepts the following values: - "on": request watch patterns for each subdirectory (as before) - "off": do not request subdirectory watch patterns - "auto": same as "on" for VS Code, "off" for all others, based on the provided initializeParams.clientInfo.Name. Includes some minor cleanup for the fake editor, and fixes some stale comments. Updates golang/go#golang/go#60089 Fixes golang/go#59635 Change-Id: I1eab5c08790bd86a5910657169edcb20511c0280 Reviewed-on: https://go-review.googlesource.com/c/tools/+/496835 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.