commit | e69ba9dc007335a8518c29ced8bf5b20aa9e66fc | [log] [tgz] |
---|---|---|
author | Robert Findley <rfindley@google.com> | Wed Oct 13 16:08:27 2021 -0400 |
committer | Robert Findley <rfindley@google.com> | Thu Oct 14 14:04:14 2021 +0000 |
tree | 20dadd15426115cdc880070a23eb7b79775fbaa6 | |
parent | 88e80df821e96ca67ec657e5d6a4d87bdde32439 [diff] |
internal/lsp/cache: fix incorrect detection of useless code Our logic to detect whether suggested fixes delete unnecessary code did not take into account suggested fixes that have a command. Fixes golang/go#48938 Change-Id: I70d2bebbf7059236525117cc1f454ef726162a96 Reviewed-on: https://go-review.googlesource.com/c/tools/+/355769 Trust: Robert Findley <rfindley@google.com> Trust: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.