tree 383f9a419dd821213354e514c28b0abeeec191b2
parent 8a9207816c6df78e430bfeb90c41039dfeed6f34
author Rob Findley <rfindley@google.com> 1628519961 -0400
committer Robert Findley <rfindley@google.com> 1655403570 +0000

internal/lsp/cache: use metadataGraph.Clone in snapshot.clone

Rather than updating metadata directly in snapshot.clone, build a set of
updates to apply and call metadata.Clone.

After this change, metadata is only updated by cloning, so we can
eliminate some code that works with mutable metadata.

In the next CL we'll only update the metadata if something changed, but
this is intentionally left out of this CL to isolate the change.

Benchmark (didChange in kubernetes): ~55ms->65ms, because it is now more
work to compute uris.

For golang/go#45686

Change-Id: I048bed65760b266a209f67111c57fae29bd3e6f0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/340852
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>