tree be65200bea61dd522782a5aed81e79edd4ca3f75
parent f3c36a20991b11a5f6b0dd2049e40bcd21bc3530
author Alan Donovan <adonovan@google.com> 1674255441 -0500
committer Alan Donovan <adonovan@google.com> 1674691034 +0000

gopls/internal/lsp/source: references: support exported methods

This change extends referencesV2 to support exported methods,
avoiding the need to fall back to the old type-check-the-world
implementation. (The latter is not quite dead code yet.)

A references query on a method (C).F will compute all methods
I.F of interfaces that correspond to it, by doing a lookup
in the method set index used by the global "implementations"
operation. The found methods are then used to augment the
set of targets in the global search.

The methodsets index has been extended to save the (PkgPath,
objectpath) pair for each method, since these are the needed
inputs to the global references query. (The method's package
is not necessarily the same as that of the enclosing type's
package due to embedding.) The current encoding increases the
index size by about 10%. I suspect we could do better by
exploiting redundancy between the objectpath and fingerprint,
but there's no urgency.

Also:
- typeDeclPosition no longer returns methodID, since
  it can be derived later.
- ensure that pkg.xrefs is always set by doTypeCheck.

Change-Id: I4037dcfc1a2a710f0cb7a2f5268527e77ebfcd79
Reviewed-on: https://go-review.googlesource.com/c/tools/+/463141
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>