go/ssa: build generic function bodies
ssa now always builds the bodies of generic functions and methods.
Within the bodies of generic functions, parameterized types may appear
in Instructions.
When ssa.InstantiateGenerics is on, calls to generic functions
with ground (non-parameterized) types are built as instantiations of the
generic function bodies. Otherwise, calls to generic functions are built
as a wrapper function that delegates to the generic function body.
The ChangeType instruction can now represent a coercion to or from a
parameterized type to an instance of the type.
*ssa.Const values may now represent the zero value of any type.
The build mode of go/analysis/passes/buildssa is again
ssa.BuilderMode(0) (i.e. ssa.InstantiateGenerics is off).
This change is a stack of already reviewed CLs.
Fixes golang/go#48525
Change-Id: Ib516eba43963674c804a63e3dcdae6d4116353c9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/425496
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Tim King <taking@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
diff --git a/go/ssa/lvalue.go b/go/ssa/lvalue.go
index 455b1e5..51122b8 100644
--- a/go/ssa/lvalue.go
+++ b/go/ssa/lvalue.go
@@ -56,12 +56,12 @@
}
// An element is an lvalue represented by m[k], the location of an
-// element of a map or string. These locations are not addressable
+// element of a map. These locations are not addressable
// since pointers cannot be formed from them, but they do support
-// load(), and in the case of maps, store().
+// load() and store().
type element struct {
- m, k Value // map or string
- t types.Type // map element type or string byte type
+ m, k Value // map
+ t types.Type // map element type
pos token.Pos // source position of colon ({k:v}) or lbrack (m[k]=v)
}
@@ -86,7 +86,7 @@
}
func (e *element) address(fn *Function) Value {
- panic("map/string elements are not addressable")
+ panic("map elements are not addressable")
}
func (e *element) typ() types.Type {
