tree 3c7dbe8a03c8ed41d58ce7aee2dd74c0942fc0a6
parent c5a2fd39b72a2403dae32d544b008ff4973c8b29
author Michael Matloob <matloob@golang.org> 1565042269 -0400
committer Michael Matloob <matloob@golang.org> 1565102055 +0000

go/analysis: change AllObjectFacts and AllPackageFacts to filter facts

Facts are intended to be private to an analysis. Even though it's hard
to guarantee with the information we have that facts won't leak to the
wrong analysis, we can filter some analyses that couldn't possibly have
come from the same analysis. AllObjectFacts and AllPackageFacts will
now filter facts if their type isn't specified in an analysis's FactTypes.

Change-Id: I2794437a5810e08fe6a9652b3569c5e3c17e159f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/189037
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Dominik Honnef <dominik@honnef.co>