tree b3326dfd77003345498efbf360ad7fc0da30b5bb
parent 74543c403428e9d4047431673e74920f5b186866
author Rob Findley <rfindley@google.com> 1598028791 -0400
committer Robert Findley <rfindley@google.com> 1598029909 +0000

internal/lsp/source: fix panic in formatZeroValue for invalid type

formatZeroValue is currently only used when formatting return values for
statement completion. Per golang/go#40956, it must be possible to hit
this codepath with an invalid type.

In this case, the empty string seems like a reasonable value. Perhaps we
could do better, but fix the panic for now.

Fixes golang/go#40956

Change-Id: I45b559d41001c857cef34aea2a5ac4a9096fe950
Reviewed-on: https://go-review.googlesource.com/c/tools/+/249818
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>