tree 0d15dbf59ed1df2835f5677d28df71cb811af512
parent 0eded082dc1f0ee99678b06b3856510a21852696
author Heschi Kreinick <heschi@google.com> 1580794334 -0500
committer Rebecca Stambler <rstambler@golang.org> 1580827899 +0000

internal/imports: stop leaking listeners

(*dirInfoCache).ScanAndListen saves a listener when it's called. That
listener is a chain of callbacks that leads all the way back up to the
original caller, i.e. the gopls completion code. It needs to unregister
that listener, but in cases where the context was cancelled before it
finished its initial walk of the cache, it failed to. In gopls' case,
that means retaining the entire state of the workspace as of completion
triggering.

Return a real stop function on all paths.

Change-Id: Iff3046e627b1fa89f576371c4742fee6fdca7589
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217677
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit cf5ba95194b762765be9bcf54116447032a4d8f0)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217678
Reviewed-by: Robert Findley <rfindley@google.com>