)]}' { "commit": "330dc7d2a4276ca3af24314e6069fe8245b84af1", "tree": "e03befe0bc4daab83042f60c3dac326d4830ebae", "parents": [ "b653051172e4dcfaee2233d4c528e91769a496e1" ], "author": { "name": "Rob Findley", "email": "rfindley@google.com", "time": "Fri Oct 23 10:44:29 2020 -0400" }, "committer": { "name": "Robert Findley", "email": "rfindley@google.com", "time": "Wed Nov 04 18:18:50 2020 +0000" }, "message": "internal/lsp/cache: assign a static temp workspace dir to the first view\n\nEditors need a way to run commands in the same workspace that gopls\nsees. Longer term, we need a good solution for this that supports\nmultiple workspace folders, but for now just write the first folder\u0027s\nworkspace to a deterministic location:\n $TMPDIR/gopls-\u003cclient PID\u003e.workspace.\n\nUsing the client-provided PID allows this mechanism to work even for\nmulti-session daemons.\n\nAlong the way, simplify the snapshot reinitialization logic a bit.\n\nFixes golang/go#42126\n\nChange-Id: I5b9f454fcf1a1a8fa49a4b0a122e55e762d398b4\nReviewed-on: https://go-review.googlesource.com/c/tools/+/264618\nRun-TryBot: Robert Findley \u003crfindley@google.com\u003e\ngopls-CI: kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nTrust: Robert Findley \u003crfindley@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "9f8a7793ad8aa461d63265524f6099209799398a", "old_mode": 33188, "old_path": "gopls/internal/regtest/runner.go", "new_id": "8c5efe0f17ec22cba558c77cbd806af3a25b71ed", "new_mode": 33188, "new_path": "gopls/internal/regtest/runner.go" }, { "type": "modify", "old_id": "9eaff5596e33c1c205ee5737a0d160de95b69bd4", "old_mode": 33188, "old_path": "gopls/internal/regtest/workspace_test.go", "new_id": "1887ab4765cffea9d2b22a826b7e5fc3fc9c9fbb", "new_mode": 33188, "new_path": "gopls/internal/regtest/workspace_test.go" }, { "type": "modify", "old_id": "4afcb792a222d565794b3c4bd6e2a7c5515f80d0", "old_mode": 33188, "old_path": "internal/lsp/cache/session.go", "new_id": "36bfc50701dbb470b35ab784bfce17b7162fa36a", "new_mode": 33188, "new_path": "internal/lsp/cache/session.go" }, { "type": "modify", "old_id": "15b9855add969c2a3beb833e01417b27fb4c37c4", "old_mode": 33188, "old_path": "internal/lsp/cache/snapshot.go", "new_id": "045415f7a868acb60c5e86e62fefdafd91cb44a8", "new_mode": 33188, "new_path": "internal/lsp/cache/snapshot.go" }, { "type": "modify", "old_id": "598908a1ccac3d47fd8d8cc184e2eaf7d855773c", "old_mode": 33188, "old_path": "internal/lsp/cache/view.go", "new_id": "489504b9073d645008c5aeae5c6553c39e7edf03", "new_mode": 33188, "new_path": "internal/lsp/cache/view.go" }, { "type": "modify", "old_id": "b367293f16b57cce4185c5aec93a67e5bf92e79d", "old_mode": 33188, "old_path": "internal/lsp/fake/editor.go", "new_id": "9ef80fe1ffee548fb92c2ecf662ba707c48da1e4", "new_mode": 33188, "new_path": "internal/lsp/fake/editor.go" }, { "type": "modify", "old_id": "1c2a8bd826394389d4439eb3991db9f0649af068", "old_mode": 33188, "old_path": "internal/lsp/general.go", "new_id": "cc38cb2659a7fb8c29e95334461c609c5db4d24b", "new_mode": 33188, "new_path": "internal/lsp/general.go" }, { "type": "modify", "old_id": "e031d6d003e3cfee2c0c62a8eb38753dfca2d652", "old_mode": 33188, "old_path": "internal/lsp/lsp_test.go", "new_id": "aa73f6c02e0fd85fe90a55882b35bd7b5b47386d", "new_mode": 33188, "new_path": "internal/lsp/lsp_test.go" }, { "type": "modify", "old_id": "448c0e5862002e80460e6d6860a9700a468fbd21", "old_mode": 33188, "old_path": "internal/lsp/lsprpc/lsprpc.go", "new_id": "dc3e29c15eb556c65bbbc1f70bf5ecb4514e2007", "new_mode": 33188, "new_path": "internal/lsp/lsprpc/lsprpc.go" }, { "type": "modify", "old_id": "f7c3360c69392857717dc9e354e520e439fdfd04", "old_mode": 33188, "old_path": "internal/lsp/mod/mod_test.go", "new_id": "6ce89263e960c04c7087bc234066cb346fd2f558", "new_mode": 33188, "new_path": "internal/lsp/mod/mod_test.go" }, { "type": "modify", "old_id": "763f4d176d4b027efa86439b217156b81949555a", "old_mode": 33188, "old_path": "internal/lsp/server.go", "new_id": "058ffbc7ecc809cbe3131d9214d0d4bf928a183c", "new_mode": 33188, "new_path": "internal/lsp/server.go" }, { "type": "modify", "old_id": "ada58b5df08ca500eac73dd4ef30bab0177c4d7e", "old_mode": 33188, "old_path": "internal/lsp/source/source_test.go", "new_id": "932351e0e74a2a682a046dacbe3ae188eeb0e213", "new_mode": 33188, "new_path": "internal/lsp/source/source_test.go" }, { "type": "modify", "old_id": "390102eee6ca32f2279d99252fe100b42b175fe5", "old_mode": 33188, "old_path": "internal/lsp/source/view.go", "new_id": "fa307dffd0fa3f3ebfe06df6b52c62860b3fbf40", "new_mode": 33188, "new_path": "internal/lsp/source/view.go" }, { "type": "modify", "old_id": "c1ba89b3b18c5bf374d62e22348a8ff2efd2fd3e", "old_mode": 33188, "old_path": "internal/lsp/workspace.go", "new_id": "9b29668f5cbcf6fbf2545aefb1119718e6a8a634", "new_mode": 33188, "new_path": "internal/lsp/workspace.go" } ] }