tree 04d15d24147ea9d3207b6453e68c0051da794a5e
parent ed677e9dcd1e8f0c26e68a39f542fbd91dc75909
author Rebecca Stambler <rstambler@golang.org> 1605808071 -0500
committer Rebecca Stambler <rstambler@golang.org> 1606239481 +0000

internal/lsp: rewrite the workspace symbol marker tests

The workspace symbol tests are not really resilient to changes and
did not generate/use golden files consistently. This made it really
tricky to switch the workspace symbols defaults.

To improve the workflow, consolidate the different kinds of tests into
one function, generate and use golden files, and require that all of the
workspace symbol queries appear in one file only. Also converted the
brittle workspace symbol regtest to a marker test.

Update golang/go#41760

Change-Id: I41ccd3ae58ae08fea717c7d8e9a2a10330e8c14f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/271626
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>