| commit | 323f198cedfea95cac416c5021444bd6539aa388 | [log] [tgz] |
|---|---|---|
| author | Michael Matloob <matloob@golang.org> | Mon Nov 11 16:51:47 2019 -0500 |
| committer | Michael Matloob <matloob@golang.org> | Tue Nov 12 18:49:59 2019 +0000 |
| tree | 372257a448386789e8f790d8e939c271cc00b5e0 | |
| parent | dce577ffce43b1b9bc9e92a94a8f166396079f4b [diff] |
internal/lsp: support implementations requests for implementations in other packages Look in all packages the snapshot knows of (through a new method on snapshot called KnownPackages) and see if any of those packages contain implementations. Before, the Implementation call only looked in the current package. Much of the new complexity in implementation.go is routing through the Type to Package data in the implementsResult.pkg field so the identifier can be looked up in its correct package. Fixes golang/go#32973 Change-Id: Ifa7115b300f52fb4fb55cc00db2e7f339e8c2582 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206518 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.