tree c78ac2511bca02794d005d0e85633e2e38d1a890
parent 8c78b306b8b8f8a3cb067d717e3c76860d76340f
author Robert Findley <rfindley@google.com> 1669925420 -0500
committer Robert Findley <rfindley@google.com> 1669992981 +0000

gopls/internal/lsp/cache: fix re-entrant session locking

The session used re-entrant locking of its RWMutex viewMu, a latent bug
only avoided due to jsonrpc2 serialization. Furthermore, the read
locking in ViewOf is not even correct: ViewOf may write to viewMap for
unmapped files.

Fix this by switching to a Mutex, and delegating the ViewOf logic to a
viewOfLocked method.

Change-Id: I73f4a7b6b6569c2565c8be0dcf8f05d9c88c141c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/454635
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>